Fix how we invalidate the sbt bridge cache #5050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smarter
commented
Aug 27, 2018
smarter
commented
- Remove the correct files to actually get rid of the cache
- Only clean the cache when the bridge has been recompiled
- Make sure the bridge is compiled when compiling a bootstrapped project
- Remove the correct files to actually get rid of the cache - Only clean the cache when the bridge has been recompiled - Make sure the bridge is compiled when compiling a bootstrapped project
| val bridgePattern = s"*dotty-sbt-bridge*$dottyVersion*" | ||
|
|
||
| IO.delete((file(home) / ".sbt" / "1.0" / "zinc" / sbtOrg * bridgePattern).get) | ||
| IO.delete((file(home) / ".sbt" / "boot" * "scala-*" / sbtOrg / "sbt" * "*" * bridgePattern).get) |
There was a problem hiding this comment.
How safe is deleting wildcard files under the home directory? Looks a bit scary (both the code and especially that it's allowed). Tho apparently we already did it?
There was a problem hiding this comment.
The paths used are as precise as I can reasonably make them to limit the use of wildcards. Suggestions on making this better are welcome but I think it's fine as is.
Duhemm
approved these changes
Aug 28, 2018
|
Yeah I don't think it's worth it |
|
What would be useful is invalidating bootstrapped projects when the tasty major version is bumped but I don't know how to do that |
|
FWIW, using Zinc's scripted infrastructure this wouldn't be required, as the compiler bridges are sourced from the classes directory of the sbt projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.